PNG  IHDR* pHYs+ IDATx]n#; cdLb Ǚ[at¤_:uP}>!Usă cag޿ ֵNu`ݼTâabO7uL&y^wFٝA"l[|ŲHLN밪4*sG3|Dv}?+y߉{OuOAt4Jj.u]Gz*҉sP'VQKbA1u\`& Af;HWj hsO;ogTu uj7S3/QzUr&wS`M$X_L7r2;aE+ώ%vikDA:dR+%KzƉo>eOth$z%: :{WwaQ:wz%4foɹE[9<]#ERINƻv溂E%P1i01 |Jvҗ&{b?9g=^wζXn/lK::90KwrюO\!ջ3uzuGv^;騢wq<Iatv09:tt~hEG`v;3@MNZD.1]L:{ծI3`L(÷ba")Y.iljCɄae#I"1 `3*Bdz>j<fU40⨬%O$3cGt]j%Fߠ_twJ;ABU8vP3uEԑwQ V:h%))LfraqX-ۿX]v-\9I gl8tzX ]ecm)-cgʒ#Uw=Wlێn(0hPP/ӨtQ“&J35 $=]r1{tLuǮ*i0_;NƝ8;-vݏr8+U-kruȕYr0RnC]*ެ(M:]gE;{]tg(#ZJ9y>utRDRMdr9㪩̞zֹb<ģ&wzJM"iI( .ꮅX)Qw:9,i좜\Ԛi7&N0:asϓc];=ΗOӣ APqz93 y $)A*kVHZwBƺnWNaby>XMN*45~ղM6Nvm;A=jֲ.~1}(9`KJ/V F9[=`~[;sRuk]rєT!)iQO)Y$V ی ۤmzWz5IM Zb )ˆC`6 rRa}qNmUfDsWuˤV{ Pݝ'=Kֳbg,UҘVz2ﴻnjNgBb{? ߮tcsͻQuxVCIY۠:(V뺕 ٥2;t`@Fo{Z9`;]wMzU~%UA蛚dI vGq\r82iu +St`cR.6U/M9IENDB`---------------------- --- IMPORTANT TODO --- ---------------------- -------------------- --- NEEDED TESTS --- -------------------- - test: - service method lookups - out-of-order fields in messages (ie if the number isn't ascending) - gaps in numbers: check that the number of ranges is correct - default values - message unpack alloc failures when allocating new slab - message unpack alloc failures when allocating unknown field buffers - packed message corruption. - meta-todo: get a list of all the unpack errors together to check off --------------------- --- DOCUMENTATION --- --------------------- Document: - services - check over documentation again -------------------------- --- LOW PRIORITY STUFF --- -------------------------- - support Group (whatever it is) - proper support for extensions - slot for ranges in descriptor - extends is implemented as c-style function whose name is built from the package, the base message type-name and the member. which takes the base message and returns the value, if it is found in "unknown_values". boolean package__extension_member_name__get(Message *message, type *out); void package__extension_member_name__set_raw(type in, ProtobufCUnknownValue *to_init); ------------------------------------ --- EXTREMELY LOW PRIORITY STUFF --- ------------------------------------ - stop using qsort in the code generator: find some c++ish way to do it ---------------------------------------------- --- ISSUES WE ARE PROBABLY GOING TO IGNORE --- ---------------------------------------------- - strings may not contain NULs ------------------------- --- IDEAS TO CONSIDER --- ------------------------- - optimization: structures without repeated members could skip the ScannedMember phase - optimization: a way to ignore unknown-fields when unpacking - optimization: certain functions are not well setup for WORDSIZE==64; especially the int64 routines are inefficient that way. The best might be an internal #define WORDSIZE (sizeof(long)*8)" except w/ a real constant there, one that the preprocessor can use. I think the functions in protobuf-c.c are already tagged. - lifetime functions for messages: message__new() return a new message using an allocator with standard allocation policy message__unpack_onto(...) unpack onto an initialized message message__clear(...) clears all allocations, does not free the message itself message__free(...) free the message. [yeah, right: after typing it out, i see it's way too complicated] - switching to pure C. - Rewrite the code-generator in C, including the parser. - This would have the huge advantage that we could use ".proto" files directly, instead of having to invoke the compilers. - keep in a separate c file for static linking optimziation purposes - need alignment tests - the CAVEATS should discuss our structure-packing assumptions